New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28334][SQL][TEST] Port select.sql #25096
Conversation
Test build #107455 has finished for PR 25096 at commit
|
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
Outdated
Show resolved
Hide resolved
Test build #107466 has finished for PR 25096 at commit
|
Hi, @maropu . |
Test build #107491 has finished for PR 25096 at commit
|
I left one comment though, it looks ok to me. |
Test build #107532 has finished for PR 25096 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## What changes were proposed in this pull request? This PR is to port select.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/select.sql The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/select.out When porting the test cases, found four PostgreSQL specific features that do not exist in Spark SQL: [SPARK-28010](https://issues.apache.org/jira/browse/SPARK-28010): Support ORDER BY ... USING syntax [SPARK-28329](https://issues.apache.org/jira/browse/SPARK-28329): Support SELECT INTO syntax [SPARK-28330](https://issues.apache.org/jira/browse/SPARK-28330): Enhance query limit [SPARK-28296](https://issues.apache.org/jira/browse/SPARK-28296): Improved VALUES support Also, found one inconsistent behavior: [SPARK-28333](https://issues.apache.org/jira/browse/SPARK-28333): `NULLS FIRST` for `DESC` and `NULLS LAST` for `ASC` ## How was this patch tested? N/A Closes apache#25096 from wangyum/SPARK-28334. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
This PR is to port select.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/select.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/select.out
When porting the test cases, found four PostgreSQL specific features that do not exist in Spark SQL:
SPARK-28010: Support ORDER BY ... USING syntax
SPARK-28329: Support SELECT INTO syntax
SPARK-28330: Enhance query limit
SPARK-28296: Improved VALUES support
Also, found one inconsistent behavior:
SPARK-28333:
NULLS FIRST
forDESC
andNULLS LAST
forASC
How was this patch tested?
N/A