Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-27878][SQL] Support ARRAY(subquery) expressions #25118

Closed
wants to merge 1 commit into from

Conversation

peter-toth
Copy link
Contributor

What changes were proposed in this pull request?

This PR adds support for array creation from subquery so this example becomes valid:

select array(select c from t)

How was this patch tested?

Added new UTs.

@SparkQA
Copy link

SparkQA commented Jul 11, 2019

Test build #107542 has finished for PR 25118 at commit fcef61e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class ArraySubquery(

@maropu maropu changed the title [SPARK-27878][SQL] Support ARRAY(sub-SELECT) expressions [SPARK-27878][SQL] Support ARRAY(subquery) expressions Jul 12, 2019
@maropu
Copy link
Member

maropu commented Jul 12, 2019

Is this syntax supported in the other DBMSs, e.g., mysql and oracle? (I know pg accepts this one though)

@peter-toth
Copy link
Contributor Author

@maropu
Copy link
Member

maropu commented Jul 16, 2019

If so, I think it has a lower priority to support this syntax .... (cuz we already have the other higher priority issues you know...)

@peter-toth
Copy link
Contributor Author

If so, I think it has a lower priority to support this syntax .... (cuz we already have the other higher priority issues you know...)

Ok, got it. I keep this PR open though.

@maropu
Copy link
Member

maropu commented Jul 16, 2019

Thanks. This is just my opinion and the other developers might not think so. Its ok to keep it open for a while.

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just
a way of keeping the PR queue manageable.

If you'd like to revive this PR, please reopen it!

@github-actions github-actions bot added the Stale label Dec 26, 2019
@github-actions github-actions bot closed this Dec 27, 2019
@HyukjinKwon
Copy link
Member

Yeah, I think we shouldn't support this case for now but thanks for your contribution and analysis, @peter-toth .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants