[SPARK-28375][SQL] Make PullupCorrelatedPredicates idempotent #25145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #107631 has finished for PR 25145 at commit
|
yeshengm
reviewed
Jul 15, 2019
| @@ -279,9 +277,9 @@ object PullupCorrelatedPredicates extends Rule[LogicalPlan] with PredicateHelper | |||
| case Exists(sub, children, exprId) if children.nonEmpty => | |||
There was a problem hiding this comment.
Why we are not treating these two cases similar to ListQuery?
yeshengm
reviewed
Jul 15, 2019
| @@ -264,11 +264,9 @@ object PullupCorrelatedPredicates extends Rule[LogicalPlan] with PredicateHelper | |||
| } else { | |||
| (transformed, baseConditions) | |||
| } | |||
| (plan, stripOuterReferences(deDuplicatedConditions)) | |||
There was a problem hiding this comment.
This diff seems dicey... This might lead to unresolved outer reference after this batch.
|
@yeshengm we can go ahead with your PR, I hadn't much time in these days to fix this, I'l review it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Multiple runs of
PullupCorrelatedPredicatescan produce invalid plans. Indeed, when there is aSubquerywith aFiltera second run removes the conditions pulled by the previous run and overwrites them to nothing.The PR avoids this issue and makes
PullupCorrelatedPredicatesidempotent.How was this patch tested?
added UT