[SPARK-28460][SQL][TEST][test-hadoop3.2] Port test from HIVE-11835 #25212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Retest this please. |
|
Yes. This is a way to test this. I'm wondering if we can have a simpler test case for this. cc @gatorsmile |
This comment has been minimized.
This comment has been minimized.
HyukjinKwon
reviewed
Jul 22, 2019
...ompatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
retest this please |
|
Test build #107996 has finished for PR 25212 at commit
|
wangyum
changed the title
|
retest this please |
|
Test build #108004 has finished for PR 25212 at commit
|
|
Retest this please. |
|
Test build #108256 has finished for PR 25212 at commit
|
dongjoon-hyun
approved these changes
Jul 27, 2019
There was a problem hiding this comment.
+1, LGTM. Although this is a port from Hive, I'll merge this to the master for Hive compatibility because we have several PRs against decimal behavior changes.
Thank you, @wangyum and @HyukjinKwon .
cc @mgaido91 , @gatorsmile , @cloud-fan , @felixcheung
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HIVE-11835 fixed type
decimal(1,1)reads 0.0, 0.00, etc from text file as NULL. We fixed this issue after upgrade the build-in Hive to 2.3.5. This PR port the test from HIVE-11835.Hive test result:
https://github.com/apache/hive/blob/release-2.3.5-rc0/ql/src/test/results/clientpositive/decimal_1_1.q.out#L67-L96
How was this patch tested?
N/A