New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28534][K8S][TEST] Update node affinity for DockerForDesktop backend in PVTestsSuite #25269
Conversation
…ckend in PVTestsSuite
Kubernetes integration test starting |
Test build #108240 has finished for PR 25269 at commit
|
Kubernetes integration test status success |
cc @dbtsai |
Hi, @HyukjinKwon and @maropu . |
I run the test, but I couldn't see it passed.
It seems the pod was created successfully;
|
Hi, @maropu . Thank you for testing. |
@dongjoon-hyun oh, yeah. Thanks for the explanation! I'll try later. |
Thank you. Sorry for wasting your time due to the ambiguity. I'll update the PR. |
I updated the PR description~ |
Tested as guided:
Merged to master. |
Thank you so much, @HyukjinKwon and @maropu ! |
What changes were proposed in this pull request?
This PR aims to recover our K8s integration test suite by extending node affinity in order to pass
PVTestsSuite
inDockerForDesktop
environment, too. Previously,PVTestsSuite
fails at--deploy-mode docker-for-desktop
option because the node affinity requiresminibase
node.For
Docker Desktop
, there are two node names like the following. Note that Spark testing needs K8s v1.13 and above. So, this PR should be verified withDocker Desktop (Edge)
version. This PR adds both because next stableDocker Desktop
will have K8s v1.14.3.Docker Desktop (Stable, K8s v1.10.11)
Docker Desktop 2.1.0.0 (Edge, K8s v1.14.3, Released 2019-07-26)
How was this patch tested?
Pass the Jenkins K8s integration test (
minibase
) and installDocker Desktop 2.1.0.0 (Edge)
and run the integration test inDockerForDesktop
. Note that this fixes onlyPVTestsSuite
.