[SPARK-28531][SQL] Improve Extract Python UDFs optimizer rule to enforce idempotence #25381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
changed the title
gatorsmile
reviewed
Aug 7, 2019
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala
Outdated
Show resolved
Hide resolved
|
Test build #108786 has finished for PR 25381 at commit
|
|
Test build #108789 has finished for PR 25381 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since the action of extract python UDFs should be considered idempotent, in this PR we separate "extract Python UDFs" and "post python UDF extraction optimization" into two different batches, therefore enable the idempotence checker for "extract Python UDFs".
How was this patch tested?
Existing UTs.