Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-28541][WEBUI] Document Storage page #25445

Closed
wants to merge 6 commits into from
Closed

[SPARK-28541][WEBUI] Document Storage page #25445

wants to merge 6 commits into from

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

add an example for storage tab

How was this patch tested?

locally building

@SparkQA
Copy link

SparkQA commented Aug 14, 2019

Test build #109076 has finished for PR 25445 at commit bdc796c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

xuanyuanking
xuanyuanking reviewed Aug 17, 2019
View reviewed changes
Copy link
Member

@xuanyuanking xuanyuanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for this work! cc @gatorsmile

docs/web-ui.md Outdated
<!-- Images are downsized intentionally to improve quality on retina displays -->
</p>

Cliking the RDD name 'rdd' displays the details of data persistance, such as the data distribution on the cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you check the display of 'rdd'?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I do not get the point. Is there a rendering issue?
In the example, I set the name of the first RDD to rdd.
Thanks for reviewing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "You can click the RDD name 'rdd' for obtaining the details .... " ?

@zhengruifeng
Copy link
Contributor Author

图片

@SparkQA
Copy link

SparkQA commented Aug 19, 2019

Test build #109311 has finished for PR 25445 at commit d4d1ca4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

gatorsmile
gatorsmile reviewed Aug 19, 2019
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the storage page.

docs/web-ui.md Outdated
<!-- Images are downsized intentionally to improve quality on retina displays -->
</p>

After running above example, we can found two RDDs listed in the Storage tab. Basic information like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above example -> the above example

found -> find

docs/web-ui.md Outdated
<!-- Images are downsized intentionally to improve quality on retina displays -->
</p>

Cliking the RDD name 'rdd' displays the details of data persistance, such as the data distribution on the cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "You can click the RDD name 'rdd' for obtaining the details .... " ?

gatorsmile
gatorsmile reviewed Aug 19, 2019
View reviewed changes
docs/web-ui.md Outdated

After running the above example, we can find two RDDs listed in the Storage tab. Basic information like
storage level, number of partitions and memory overhead are provided. Note that the newly persisted RDDs
or DataFrames are not shown in the tab before they are materialized, to monitor a specific RDD or DataFrame,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"materialized, to" -> "materialized. To

@SparkQA
Copy link

SparkQA commented Aug 19, 2019

Test build #109314 has finished for PR 25445 at commit c34cc46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 19, 2019

Test build #109318 has finished for PR 25445 at commit 9d3447d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen requested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar question about whether we want a screenshot with a Spark version number in it. The header could just be removed. I don't think it's a big deal either way.

docs/web-ui.md Outdated
<!-- Images are downsized intentionally to improve quality on retina displays -->
</p>

You can click the RDD name 'rdd' for obtaining the details of data persistance, such as the data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

persistance -> persistence

@zhengruifeng
Copy link
Contributor Author

@srowen Thanks for reviewing! I had move the header outside in d4d1ca4

There were two screenshots of the built docs, and I just deleted the old one with version number in it.

@SparkQA
Copy link

SparkQA commented Aug 20, 2019

Test build #109381 has finished for PR 25445 at commit 7d99ad2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Aug 21, 2019

Merged to master

@srowen srowen closed this in c4257b1 Aug 21, 2019
@zhengruifeng zhengruifeng deleted the doc_ui_storage branch August 21, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuanyuanking xuanyuanking xuanyuanking left review comments

@gatorsmile gatorsmile gatorsmile left review comments

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
DOCUMENTATION WEB UI
Projects
None yet
Milestone
No milestone
6 participants
@zhengruifeng @SparkQA @srowen @xuanyuanking @gatorsmile @dongjoon-hyun