Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-28737][CORE] Update Jersey to 2.29 #25455

Closed
wants to merge 1 commit into from
Closed

[SPARK-28737][CORE] Update Jersey to 2.29 #25455

wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Aug 14, 2019

What changes were proposed in this pull request?

Update Jersey to 2.27+, ideally 2.29, for possible JDK 11 fixes.

How was this patch tested?

Existing tests.

@srowen srowen self-assigned this Aug 14, 2019
@SparkQA
Copy link

SparkQA commented Aug 14, 2019

Test build #109124 has finished for PR 25455 at commit ad2317c.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [WIP][SPARK-28737][CORE] Update Jersey to 2.29 [WIP][SPARK-28737][CORE][test-hadoop3.2] Update Jersey to 2.29 Aug 14, 2019
@dongjoon-hyun
Copy link
Member

Retest this please.

@dongjoon-hyun dongjoon-hyun changed the title [WIP][SPARK-28737][CORE][test-hadoop3.2] Update Jersey to 2.29 [WIP][SPARK-28737][CORE] Update Jersey to 2.29 Aug 14, 2019
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 14, 2019 •
edited

Interesting, in this PR, I also saw the same 500 error failure (JDK8/Hadoop-3.2)

[info] UISeleniumSuite:
...
[info] - effects of unpersist() / persist() should be reflected *** FAILED *** (1 second, 120 milliseconds)
[info]   java.lang.RuntimeException: got code: 500 when getting http://amp-jenkins-worker-05.amp:38637/api/v1/applications/local-1565819875887/storage/rdd w/ error: Some(<html>
[info] <head>
[info] <meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>

cc @wangyum

@srowen
Copy link
Member Author

srowen commented Aug 14, 2019

Yep this one doesn't seem straightforward. I'll work on figuring out what's the new error on update. I feel like I tried this a while ago and ran into similar problems. It seems to be mostly that Jersey reorganized its modules and some new ones must be included.

@SparkQA
Copy link

SparkQA commented Aug 14, 2019

Test build #109126 has finished for PR 25455 at commit f6c4ed1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 14, 2019

Test build #109128 has finished for PR 25455 at commit f6c4ed1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 15, 2019

Test build #109132 has finished for PR 25455 at commit 3e0b534.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member

wangyum commented Aug 15, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Aug 15, 2019

Test build #109137 has finished for PR 25455 at commit 3e0b534.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen changed the title [WIP][SPARK-28737][CORE] Update Jersey to 2.29 [SPARK-28737][CORE] Update Jersey to 2.29 Aug 15, 2019
@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #109160 has finished for PR 25455 at commit 57add37.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #109205 has started for PR 25455 at commit 57add37.

@srowen
Copy link
Member Author

srowen commented Aug 16, 2019

The test appeared to pass actually, but let me re-run it.

@dongjoon-hyun
Copy link
Member

Yes. It fails at GitHub posting. It seems to be GitHub outage.

Tests passed.
Attempting to post to Github...
Failed to post message to Github.
 > urllib_status: Temporary failure in name resolution
 > data: {"body": "**[Test build #109205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109205/testReport)** for PR 25455 at commit [`57add37`](https://github.com/apache/spark/commit/57add373ba6cc95730f3f57f9e5b2deb13ab121a).\n * This patch passes all tests.\n * This patch merges cleanly.\n * This patch adds no public classes."}

@dongjoon-hyun
Copy link
Member

Oops. Sorry. Although #25474 touches the same files, I thought it's okay because it touches a different part. Could you rebase once more?

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #4833 has finished for PR 25455 at commit 57add37.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #109236 has finished for PR 25455 at commit 431f3d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun
dongjoon-hyun approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.
Thank you, @srowen and @wangyum .

@dongjoon-hyun dongjoon-hyun mentioned this pull request Aug 16, 2019
Closed
@srowen srowen deleted the SPARK-28737 branch August 28, 2019 13:41
@LuciferYang LuciferYang mentioned this pull request Sep 21, 2020
Closed
Agirish pushed a commit to HPEEzmeral/apache-spark that referenced this pull request May 5, 2022
@srowen
[SPARK-28737][CORE] Update Jersey to 2.29
ab74a5f 
## What changes were proposed in this pull request?

Update Jersey to 2.27+, ideally 2.29, for possible JDK 11 fixes.

## How was this patch tested?

Existing tests.

Closes apache#25455 from srowen/SPARK-28737.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>

(cherry picked from commit c9b49f3)
udaynpusa pushed a commit to mapr/spark that referenced this pull request Jan 30, 2024
@srowen @ekrivokonmapr
[SPARK-28737][CORE] Update Jersey to 2.29
a2da903 
## What changes were proposed in this pull request?

Update Jersey to 2.27+, ideally 2.29, for possible JDK 11 fixes.

## How was this patch tested?

Existing tests.

Closes apache#25455 from srowen/SPARK-28737.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>

(cherry picked from commit c9b49f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

@srowen srowen

Labels
BUILD SPARK CORE
Projects
None yet
Milestone
No milestone
4 participants
@srowen @SparkQA @dongjoon-hyun @wangyum