Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-3701][MLLIB] update python linalg api and small fixes #2548

Closed
wants to merge 6 commits into from
Closed

[SPARK-3701][MLLIB] update python linalg api and small fixes #2548

wants to merge 6 commits into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Sep 26, 2014

  1. doc updates
  2. simple checks on vector dimensions
  3. use column major for matrices

@davies @jkbradley

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2548 at commit 131ee3a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2548 at commit 131ee3a.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20874/

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2548 at commit ef853f9.

  • This patch merges cleanly.

jkbradley
jkbradley reviewed Sep 26, 2014
View reviewed changes
python/pyspark/mllib/linalg.py
Matrix.__init__(self, nRow, nCol)
assert len(values) == nRow * nCol
"""
Column-majored dense matrix.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure "major" is more common than "majored" (I think this typo exists elsewhere in MLlib too.)

@jkbradley
Copy link
Member

LGTM (other than the one typo)

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2548 at commit ef853f9.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20875/

@JoshRosen
Copy link
Contributor

Build failure is my fault, due to merging #2351. I've reverted it and re-triggered your unit tests.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2548 at commit ef853f9.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2548 at commit ef853f9.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have started for PR 2548 at commit 067ef71.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have finished for PR 2548 at commit 067ef71.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20890/

@JoshRosen
Copy link
Contributor

This new failure looks like it might be legitimate.

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have started for PR 2548 at commit fefce00.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have finished for PR 2548 at commit fefce00.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20998/

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have started for PR 2548 at commit 75f2fcc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have finished for PR 2548 at commit 75f2fcc.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20999/

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have started for PR 2548 at commit 116b5db.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2548 at commit 116b5db.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21005/

@mengxr
Copy link
Contributor Author

mengxr commented Sep 30, 2014

test this please

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have started for PR 2548 at commit 116b5db.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2548 at commit 116b5db.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21009/

jkbradley
jkbradley reviewed Sep 30, 2014
View reviewed changes
python/pyspark/mllib/linalg.py
else:
raise Exception("Cannot call dot with %d-dimensional array" % other.ndim)
elif other.ndim > 2:
raise ValueError("Cannot call dot with %d-dimentaional array" % other.ndim)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "dimentaional"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@jkbradley
Copy link
Member

@mengxr LGTM, except for the typo and question above

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have started for PR 2548 at commit 6dce2df.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2548 at commit 6dce2df.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21064/

@mengxr
Copy link
Contributor Author

mengxr commented Sep 30, 2014

test this please

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have started for PR 2548 at commit 6dce2df.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2548 at commit 6dce2df.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21069/

@mengxr
Copy link
Contributor Author

mengxr commented Oct 1, 2014

Merged into master. Thanks @jkbradley for review!

@asfgit asfgit closed this in d75496b Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@mengxr @SparkQA @AmplabJenkins @jkbradley @JoshRosen