[SPARK-28875][DSTREAMS][SS][TESTS] Add Task retry tests to make sure new consumer used #25582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #109732 has finished for PR 25582 at commit
|
gaborgsomogyi
changed the title
gaborgsomogyi
changed the title
|
cc @HeartSaVioR to reflect discussion #22138 (comment) |
|
Test build #109734 has finished for PR 25582 at commit
|
gaborgsomogyi
changed the title
gaborgsomogyi
changed the title
HeartSaVioR
approved these changes
Aug 26, 2019
| val consumer2 = KafkaDataConsumer.acquire(topicPartition, kafkaParams, true) | ||
| consumer2.release() | ||
|
|
||
| // The first consumer should be removed from cache and new non-cached should be returned |
There was a problem hiding this comment.
I'd say consumer2 should be cached as it's created after invalidation, but here you only address test so that's OK.
| @@ -78,7 +78,7 @@ private[kafka010] sealed trait KafkaDataConsumer { | |||
| def release(): Unit | |||
|
|
|||
| /** Reference to the internal implementation that this wrapper delegates to */ | |||
| protected def internalConsumer: InternalKafkaConsumer | |||
| def internalConsumer: InternalKafkaConsumer | |||
There was a problem hiding this comment.
That's technically private[kafka010] as class scope so seems OK.
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When Task retry happens with Kafka source then it's not known whether the consumer is the issue so the old consumer removed from cache and new consumer created. The feature works fine but not covered with tests.
In this PR I've added such test for DStreams + Structured Streaming.
Why are the changes needed?
No such tests are there.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing + new unit tests.