[SPARK-28000][SQL][TEST] Port comments.sql #25588
Conversation
|
|
||
| SELECT 'before multi-line' AS fourth; | ||
| -- [SPARK-28880] ANSI SQL: Bracketed comments | ||
| /* This is an example of SQL which should not execute: |
There was a problem hiding this comment.
Do we need to comment these unsupported cases?
There was a problem hiding this comment.
I think its ok to comment out this case.
|
Test build #109769 has finished for PR 25588 at commit
|
|
retest this please |
|
Test build #109816 has finished for PR 25588 at commit
|
|
retest this please |
|
Test build #109821 has finished for PR 25588 at commit
|
| -- | ||
| -- | ||
| -- COMMENTS | ||
| -- https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/comments.sql |
There was a problem hiding this comment.
Shall we use BETA3 from now? I believe it will be the same with BETA2.
There was a problem hiding this comment.
Yes. Changed it to REL_12_BETA3.
|
Test build #109983 has finished for PR 25588 at commit
|
|
retest this please |
|
Test build #109984 has finished for PR 25588 at commit
|
|
I am merging this to complete this porting tests. Merged to master. |
## What changes were proposed in this pull request? This PR is to port comments.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA3/src/test/regress/sql/comments.sql The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA3/src/test/regress/expected/comments.out When porting the test cases, found one PostgreSQL specific features that do not exist in Spark SQL: [SPARK-28880](https://issues.apache.org/jira/browse/SPARK-28880): ANSI SQL: Bracketed comments ## How was this patch tested? N/A Closes apache#25588 from wangyum/SPARK-28000. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR is to port comments.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA3/src/test/regress/sql/comments.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA3/src/test/regress/expected/comments.out
When porting the test cases, found one PostgreSQL specific features that do not exist in Spark SQL:
SPARK-28880: ANSI SQL: Bracketed comments
How was this patch tested?
N/A