Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28881][PYTHON][TESTS][FOLLOW-UP] Use SparkSession(SparkContext(...)) to prevent for Spark conf to affect other tests #25603

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to match the test with branch-2.4. See #25593 (comment)

Seems using SparkSession.builder with Spark conf possibly affects other tests.

Why are the changes needed?

To match with branch-2.4 and to make easier to backport.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Test was fixed.

@SparkQA
Copy link

SparkQA commented Aug 28, 2019

Test build #109838 has finished for PR 25603 at commit a0322e6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Merged to master.

@dongjoon-hyun
Copy link
Member

Late LGTM.

@HyukjinKwon HyukjinKwon deleted the SPARK-28881-followup branch March 3, 2020 01:18
rshkv pushed a commit to palantir/spark that referenced this pull request Jun 4, 2020
…(...)) to prevent for Spark conf to affect other tests

### What changes were proposed in this pull request?

This PR proposes to match the test with branch-2.4. See apache#25593 (comment)

Seems using `SparkSession.builder` with Spark conf possibly affects other tests.

### Why are the changes needed?
To match with branch-2.4 and to make easier to backport.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
Test was fixed.

Closes apache#25603 from HyukjinKwon/SPARK-28881-followup.

Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
rshkv pushed a commit to palantir/spark that referenced this pull request Jun 5, 2020
…(...)) to prevent for Spark conf to affect other tests

### What changes were proposed in this pull request?

This PR proposes to match the test with branch-2.4. See apache#25593 (comment)

Seems using `SparkSession.builder` with Spark conf possibly affects other tests.

### Why are the changes needed?
To match with branch-2.4 and to make easier to backport.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
Test was fixed.

Closes apache#25603 from HyukjinKwon/SPARK-28881-followup.

Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants