[SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors #25639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @felixcheung |
|
Test build #109976 has finished for PR 25639 at commit
|
|
cc @srowen |
mgaido91
reviewed
Aug 31, 2019
srowen
reviewed
Aug 31, 2019
srowen
approved these changes
Aug 31, 2019
mgaido91
approved these changes
Aug 31, 2019
felixcheung
approved these changes
Sep 1, 2019
|
Thanks all. I will try to merge this tomorrow. |
|
Merged to master. Thanks all for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When Initializing factors in ALS, we should use
mapPartitionsinstead of currentmap, so we can preserve existing partition of the RDD ofInBlock. The RDD ofInBlockis already partitioned by src block id. We don't change the partition when initializing factors.Why are the changes needed?
This patch can reduce unnecessary shuffle after initializing factors.
Does this PR introduce any user-facing change?
No
How was this patch tested?
It should not change existing tests. It should pass added test that verifies shuffle dependency of factor RDDs.