Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28141][SQL] Support special date values #25708
[SPARK-28141][SQL] Support special date values #25708
Changes from 7 commits
c5034a8
695a6c6
ebc5b02
2663542
edda1f2
8d023ec
775c7ec
be787f4
f356b72
864e456
e237b27
0055a8a
4fb8834
9a2349b
6da7905
d57e11e
33befed
e2275d4
dabb6ec
ce7e04d
0fd86a0
92c5509
254567d
d61fdc7
03d3126
106524b
0b0e5d4
ff92531
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, (this is not related to this pr though),
scala.Option<Integer>
is ok for java compilers/jvm? @rednaxelafx I remember that jdk compilers cannot compile this statement: #21770 (comment) because it seems the compilers erase the returned type fromscala.Option<Integer>
toscala.Option<Object>
. I'm not sure why janino accepts this though....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just put the gen'd code for other reviewers;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, there is the risk that
today
contains previous day if we were unlucky and the test was executed at the end of the day. Maybe, need to introduce some tolerance.