[SPARK-29275][SQL][DOC] Describe special date/timestamp values in the SQL migration guide #25948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @srowen Please, take a look at this. |
|
Test build #111481 has finished for PR 25948 at commit
|
srowen
approved these changes
Sep 27, 2019
docs/sql-migration-guide.md
Outdated
| - `now` - the date of running the current query. It has the same notion as today. | ||
| For example `SELECT date 'tomorrow' - date 'yesterday';` should output `2`. Here are special timestamp values: | ||
| - `epoch [zoneId]` - 1970-01-01 00:00:00+00 (Unix system time zero) | ||
| - `today [zoneId]` - midnight today. |
There was a problem hiding this comment.
Shall we remove the . at the end? For line 206 and 209, it might be natural. This line might be better be consistent with the following lines (213/214).
There was a problem hiding this comment.
I removed all dots because some items don't form complete sentences, and others must not as well for consistency .
dongjoon-hyun
approved these changes
Sep 27, 2019
|
Test build #111491 has finished for PR 25948 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updated the SQL migration guide regarding to recently supported special date and timestamp values, see #25716 and #25708.
Closes #25834
Why are the changes needed?
To let users know about new feature in Spark 3.0.
Does this PR introduce any user-facing change?
No