[SPARK-29357][SQL][TESTS] Fix flaky test by changing to use AtomicLong #26020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #111765 has finished for PR 26020 at commit
|
|
retest this please |
HyukjinKwon
reviewed
Oct 4, 2019
There was a problem hiding this comment.
@xuanyuanking, can you file a new JIRA for trackability? SPARK-25159 was fixed in 2.4.0 and fixed version of the JIRA gets confused when this is merged.
xuanyuanking
changed the title
|
Sure, fill the new JIRA SPARK-29357 to track this. |
|
Test build #111769 has finished for PR 26020 at commit
|
srowen
approved these changes
Oct 4, 2019
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Oct 4, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change to use AtomicLong instead of a var in the test.
Why are the changes needed?
Fix flaky test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.