[SPARK-3756] [Core]check exception is caused by an address-port collision properly #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scwf
changed the title
|
Can one of the admins verify this patch? |
| @@ -1470,6 +1472,7 @@ private[spark] object Utils extends Logging { | |||
| return true | |||
| } | |||
| isBindCollision(e.getCause) | |||
| case e: MultiException => e.getThrowables.map(ex => isBindCollision(ex)).reduceLeft(_ || _) | |||
There was a problem hiding this comment.
I think you can just write e.getThrowables.exists(isBindCollision)?
There was a problem hiding this comment.
yes, thanks, more cleanly
|
Jenkins, test this please. LGTM pending tests. |
|
QA tests have started for PR 2611 at commit
|
|
QA tests have finished for PR 2611 at commit
|
|
Test PASSed. |
| @@ -23,6 +23,8 @@ import java.nio.ByteBuffer | |||
| import java.util.{Properties, Locale, Random, UUID} | |||
| import java.util.concurrent.{ThreadFactory, ConcurrentHashMap, Executors, ThreadPoolExecutor} | |||
|
|
|||
| import org.eclipse.jetty.util.MultiException | |||
There was a problem hiding this comment.
too late (already merged) but this should be grouped with the other imports below :(
There was a problem hiding this comment.
very sorry for this, should i make a PR to fix this?
asfgit
pushed a commit
that referenced
this pull request
Oct 1, 2014
…sion properly Jetty server use MultiException to handle exceptions when start server refer https://github.com/eclipse/jetty.project/blob/jetty-8.1.14.v20131031/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java So in ```isBindCollision``` add the logical to cover MultiException Author: scwf <wangfei1@huawei.com> Closes #2611 from scwf/fix-isBindCollision and squashes the following commits: 984cb12 [scwf] optimize the fix 3a6c849 [scwf] fix bug in isBindCollision (cherry picked from commit 2fedb5d) Signed-off-by: Patrick Wendell <pwendell@gmail.com> Conflicts: core/src/main/scala/org/apache/spark/util/Utils.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jetty server use MultiException to handle exceptions when start server
refer https://github.com/eclipse/jetty.project/blob/jetty-8.1.14.v20131031/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java
So in
isBindCollisionadd the logical to cover MultiException