[SPARK-29468][SQL] Change Literal.sql to be correct for floats. #26114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #112060 has finished for PR 26114 at commit
|
|
I kept the new test suite even though the hive tests were revealed to also be relevant, since I think they're not quite the same thing (the hive tests don't verify the output can be re-parsed) and it's weird to rely only on hive module tests for a SQL core functionality. |
|
Test build #112077 has finished for PR 26114 at commit
|
|
shall we update the old test suite to do roundtrip? We can also move it to catalyst. |
cloud-fan
approved these changes
Oct 16, 2019
|
Test build #112151 has finished for PR 26114 at commit
|
|
thanks, merging to master! |
HyukjinKwon
reviewed
Oct 23, 2019
| @@ -370,7 +390,7 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression { | |||
| case _ if v.isNaN => "'NaN'" | |||
| case Float.PositiveInfinity => "'Infinity'" | |||
| case Float.NegativeInfinity => "'-Infinity'" | |||
| case _ => v | |||
| case _ => s"'$v'" | |||
There was a problem hiding this comment.
No big deal but it could be just val castedValue = s"'$v'"
scala> s"'${Double.NaN}'"
res0: String = 'NaN'
scala> s"'${Float.NegativeInfinity}'"
res1: String = '-Infinity'
scala> s"'${Float.PositiveInfinity}'"
res2: String = 'Infinity'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change Literal.sql to output CAST('fpValue' AS FLOAT) instead of CAST(fpValue AS FLOAT) as the SQL for a floating point literal.
Why are the changes needed?
The old version doesn't work for very small floating point numbers; the value will fail to parse if it doesn't fit in a DECIMAL(38).
This doesn't apply to doubles because they have special literal syntax.
Does this PR introduce any user-facing change?
Not really.
How was this patch tested?
New unit tests.