New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands #26237
Conversation
cc: @cloud-fan / @viirya / @rdblue |
Test build #112576 has finished for PR 26237 at commit
|
Test build #112608 has finished for PR 26237 at commit
|
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (I left two minor comments, @imback82 ).
Thank you, @imback82 , @cloud-fan , @viirya . The last commit is only comment and test case name changes in Merged to master. |
Thanks everyone! |
Test build #112625 has finished for PR 26237 at commit
|
What changes were proposed in this pull request?
Add UncacheTableStatement and make UNCACHE TABLE go through the same catalog/table resolution framework of v2 commands.
Why are the changes needed?
It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g.
Does this PR introduce any user-facing change?
yes. When running UNCACHE TABLE, Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog.
How was this patch tested?
New unit tests