[SPARK-26985][CORE] Fix "access only some column of the all of columns " for big endian architecture #26254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes specific to s390x
srowen
reviewed
Oct 25, 2019
| @@ -47,7 +47,7 @@ | |||
| static { | |||
| boolean _unaligned; | |||
| String arch = System.getProperty("os.arch", ""); | |||
| if (arch.equals("ppc64le") || arch.equals("ppc64")) { | |||
| if (arch.equals("ppc64le") || arch.equals("ppc64") || arch.matches("s390x")) { | |||
There was a problem hiding this comment.
Added a commit with the change arch.equals("s390x"), as it is on master branch.
|
Test build #4905 has finished for PR 26254 at commit
|
Added arch.equals("s390x")
|
Test build #4906 has started for PR 26254 at commit |
|
Test build #4907 has finished for PR 26254 at commit
|
srowen
pushed a commit
that referenced
this pull request
Oct 29, 2019
…s " for big endian architecture continuation to #24861 As mentioned by srowen, added changes specific to s390x on branch-2.4. > The change is in the master branch so it will be released with Spark 3.0 right now. It is not in branch-2.4 or others. I'm saying it's fine to open a PR for 2.4 too, as it needs a very slightly different change, and then it could be part of 2.4. Yes, you need a new PR. This one is merged and does not cherry-pick into 2.4. Please review. Closes #26254 from vibhutisawant/branch-2.4. Authored-by: vibhutisawant <41043754+vibhutisawant@users.noreply.github.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
|
Merged to 2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation to #24861
As mentioned by @srowen, added changes specific to s390x on branch-2.4.
Please review.