Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-29603][YARN] Support application priority for YARN priority scheduling #26255

Closed
wants to merge 4 commits into from
Closed

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Oct 25, 2019

What changes were proposed in this pull request?

Priority for YARN to define pending applications ordering policy, those with higher priority have a better opportunity to be activated. YARN CapacityScheduler only.

Why are the changes needed?

Ordering pending spark apps

Does this PR introduce any user-facing change?

add a conf

How was this patch tested?

add ut

@SparkQA
Copy link

SparkQA commented Oct 25, 2019

Test build #112662 has finished for PR 26255 at commit 464dab4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 25, 2019

Test build #112665 has finished for PR 26255 at commit 9c83b3e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yaooqinn
Copy link
Member Author

cc @jerryshao @vanzin @cloud-fan, thanks in advance

@abellina
Copy link
Contributor

@yaooqinn Might point out in the config documentation that FIFO policy is required for priority (it is default in CapacityScheduler, but could be set to FAIR).

@yaooqinn yaooqinn changed the title [SPARK-29603][YARN] Support priority for applications on yarn [SPARK-29603][YARN] Support application priority for YARN priority scheduling Oct 28, 2019
@SparkQA
Copy link

SparkQA commented Oct 28, 2019

Test build #112747 has finished for PR 26255 at commit 3ab8d9f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -419,6 +419,15 @@ To use a custom metrics.properties for the application master and executors, upd
in YARN ApplicationReports, which can be used for filtering when querying YARN apps.
</td>
</tr>
<tr>
<td><code>spark.yarn.app.priority</code></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any configs that use .app, so I'd call this just spark.yarn.priority.

<td>(none)</td>
<td>
Application priority for YARN to define pending applications ordering policy, those with higher
integer value have a better opportunity to be activated. Currently Application priority is supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Currently, YARN only supports application priority when using FIFO ordering policy."


sparkConf.get(APPLICATION_PRIORITY) match {
case Some(v) => appContext.setPriority(Priority.newInstance(v))
case None => logDebug(s"${APPLICATION_PRIORITY.key} is not set. " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This debug message is not really useful. Just do sparkConf.get(...).foreach.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@SparkQA
Copy link

SparkQA commented Nov 6, 2019

Test build #113300 has finished for PR 26255 at commit 0f70dbc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Nov 6, 2019

Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants