Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-27653][SQL][FOLLOWUP] Fix since version of min_by/max_by #26264

Closed
wants to merge 1 commit into from
Closed

[SPARK-27653][SQL][FOLLOWUP] Fix since version of min_by/max_by #26264

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 25, 2019

What changes were proposed in this pull request?

This is a follow-up of #24557 to fix since version.

Why are the changes needed?

This is found during 3.0.0-preview preparation.
The version will be exposed to our SQL document like the following. We had better fix this.

Does this PR introduce any user-facing change?

Yes. It's exposed at DESC FUNCTION EXTENDED SQL command and SQL doc, but this is new at 3.0.0.

How was this patch tested?

Manual.

spark-sql> DESC FUNCTION EXTENDED min_by;
Function: min_by
Class: org.apache.spark.sql.catalyst.expressions.aggregate.MinBy
Usage: min_by(x, y) - Returns the value of `x` associated with the minimum value of `y`.
Extended Usage:
    Examples:
      > SELECT min_by(x, y) FROM VALUES (('a', 10)), (('b', 50)), (('c', 20)) AS tab(x, y);
       a

    Since: 3.0.0

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Oct 25, 2019

cc @cloud-fan , @viirya , @JoshRosen
Also, cc @jiangxb1987

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27653][SQL][FOLLOWUP] Fix since version [SPARK-27653][SQL][FOLLOWUP] Fix since version of min_by/max_by Oct 25, 2019
@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @viirya !

@SparkQA
Copy link

SparkQA commented Oct 26, 2019

Test build #112694 has finished for PR 26264 at commit de0f7a9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

The failure is irrelevant to this PR and also it passed all SQL tests.

  • KafkaMicroBatchV1SourceSuite.subscribing topic by pattern from earliest offsets (failOnDataLoss: true)

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-27653 branch October 26, 2019 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants