[SPARK-29648][SQL][TESTS] Port limit.sql #26311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
commented
Oct 30, 2019
| -- Test null limit and offset. The planner would discard a simple null | ||
| -- constant, so to ensure executor is exercised, do this: | ||
| -- [SPARK-29650] Discard a NULL constant in LIMIT | ||
| select * from int8_tbl limit (case when random() < 0.5 then bigint(null) end); |
There was a problem hiding this comment.
|
Test build #112892 has finished for PR 26311 at commit
|
|
retest this please |
|
Test build #112898 has finished for PR 26311 at commit
|
|
Test build #112894 has finished for PR 26311 at commit
|
| -- select sum(tenthous) as s1, sum(tenthous) + random()*0 as s2 | ||
| -- from tenk1 group by thousand order by thousand limit 3; | ||
|
|
||
| select sum(tenthous) as s1, sum(tenthous) + random()*0 as s2 |
There was a problem hiding this comment.
Although I believe Apache Spark behavior random()*0 == 0.0 is more natural, do we have a JIRA issue for this difference from PostgreSQL where random()*0 == 0?
There was a problem hiding this comment.
Sorry, but I missed your point and the result seems to be the same;
select sum(tenthous) as s1, sum(tenthous) + random()*0 as s2
from tenk1 group by thousand order by thousand limit 3;
s1 | s2
-------+-------
45000 | 45000
45010 | 45010
45020 | 45020
(3 rows)
Also, I tried below;
postgres=# select * from (values (1)) t(v) where random() * 0.0 = 0.0;
v
---
1
(1 row)
scala> sql("""select * from (values (1)) t(v) where random() * 0.0 = 0.0""").show()
+---+
| v|
+---+
| 1|
+---+
What's the difference here?
There was a problem hiding this comment.
The generated result is not the same in this PR.
dongjoon-hyun
approved these changes
Nov 5, 2019
|
Then, merged to master! Thank you, @maropu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR ports limit.sql from PostgreSQL regression tests https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/sql/limit.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/expected/limit.out
Why are the changes needed?
To check behaviour differences between Spark and PostgreSQL
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins. And, Comparison with PgSQL results