Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-29590][WEBUI]JDBC/ODBC tab in the spark UI support hide tables, to make it consistent with other tabs. #26353

Closed
wants to merge 3 commits into from

Conversation

shahidki31
Copy link
Contributor

What changes were proposed in this pull request?

Currently, JDBC/ODBC tab in the WEBUI doesn't support hiding table. Other tabs in the web ui like, Jobs, stages, SQL etc supports hiding table (refer #22592).
In this PR, added the support for hide table in the jdbc/odbc tab also.

Why are the changes needed?

Spark ui about the contents of the form need to have hidden and show features, when the table records very much. Because sometimes you do not care about the record of the table, you just want to see the contents of the next table, but you have to scroll the scroll bar for a long time to see the contents of the next table.

Does this PR introduce any user-facing change?

No, except support of hide table

How was this patch tested?

Manually tested
Screenshot 2019-11-01 at 12 10 05 PM
Screenshot 2019-11-01 at 12 10 43 PM

@SparkQA
Copy link

SparkQA commented Nov 1, 2019

Test build #113077 has finished for PR 26353 at commit e86b15a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait HasRelativeError extends Params
  • class _ImputerParams(HasInputCol, HasInputCols, HasOutputCol, HasOutputCols, HasRelativeError):
  • class _OneHotEncoderParams(HasInputCol, HasInputCols, HasOutputCol, HasOutputCols,
  • class _RobustScalerParams(HasInputCol, HasOutputCol, HasRelativeError):
  • class HasRelativeError(Params):
  • class ResolveCoalesceHints(conf: SQLConf) extends Rule[LogicalPlan]
  • case class AlterTableRecoverPartitionsStatement(
  • case class AlterTableRenamePartitionStatement(
  • case class DropNamespaceStatement(
  • case class LoadDataStatement(
  • case class ShowColumnsStatement(
  • case class DropNamespace(
  • case class DataSourceV2ScanRelation(
  • case class OptimizeLocalShuffleReader(conf: SQLConf) extends Rule[SparkPlan]
  • case class LocalShuffleReaderExec(child: QueryStageExec) extends UnaryExecNode
  • case class DropNamespaceExec(

@shahidki31
Copy link
Contributor Author

cc @srowen Kindly review

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113141 has finished for PR 26353 at commit 5b8f45d.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113144 has finished for PR 26353 at commit 4271589.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shahidki31
Copy link
Contributor Author

Retest this please

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK for consistency. Looks good pending tests.

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113175 has finished for PR 26353 at commit 4271589.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shahidki31
Copy link
Contributor Author

Thanks @srowen , I have tested manually also,

Screenshot 2019-11-04 at 1 17 26 PM

@srowen srowen closed this in 9023c69 Nov 4, 2019
@srowen
Copy link
Member

srowen commented Nov 4, 2019

Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants