Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-29746][ML] Implement validateInputType in Normalizer/ElementwiseProduct/PolynomialExpansion #26388

Closed
wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

This PR implements validateInput in ElementwiseProduct, Normalizer and PolynomialExpansion.

Why are the changes needed?

UnaryTransformer has abstract method validateInputType and call it in transformSchema, but this method is not implemented in ElementwiseProduct, Normalizer and PolynomialExpansion.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

@SparkQA
Copy link

SparkQA commented Nov 4, 2019

Test build #113220 has finished for PR 26388 at commit 432bd59.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

@srowen One more to review. Thanks!

@zhengruifeng
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Nov 5, 2019

Test build #113257 has finished for PR 26388 at commit 432bd59.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Nov 6, 2019

Test build #113293 has finished for PR 26388 at commit 432bd59.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in 8353000 Nov 6, 2019
@srowen
Copy link
Member

srowen commented Nov 6, 2019

Merged to master

@huaxingao
Copy link
Contributor Author

Thanks a lot! @srowen @zhengruifeng

@huaxingao huaxingao deleted the spark-29746 branch November 6, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants