New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][SPARK-29750][BUILD] Avoid dependency from joda-time #26392
Conversation
Test build #113242 has finished for PR 26392 at commit
|
@@ -125,7 +125,6 @@ jetty-6.1.26.jar | |||
jetty-sslengine-6.1.26.jar | |||
jetty-util-6.1.26.jar | |||
jline-2.14.6.jar | |||
joda-time-2.10.5.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, joda-time-2.9.9.jar
seems to occur transitively. Could you check the dependency tree and remove that, too?
+++ b/dev/pr-deps/spark-deps-hadoop-2.7
@@ -125,6 +125,7 @@ jetty-6.1.26.jar
jetty-sslengine-6.1.26.jar
jetty-util-6.1.26.jar
jline-2.14.6.jar
+joda-time-2.9.9.jar
jodd-core-3.5.2.jar
jpam-1.1.jar
json4s-ast_2.12-3.6.6.jar
@@ -139,6 +139,7 @@ jersey-server-2.29.jar | |||
jetty-webapp-9.4.18.v20190429.jar | |||
jetty-xml-9.4.18.v20190429.jar | |||
jline-2.14.6.jar | |||
joda-time-2.8.1.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ur, are you suggesting to have two difference (lower) joda-time version in this commit??? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I'm -1 to downgrade like this. If this PR is not aiming the removal of joda-time
completely, let's not do this.
@dongjoon-hyun You are so quick. |
arrow vector requires joda time in 12.x:
https://github.com/apache/arrow/blob/apache-arrow-0.12.0/java/vector/pom.xml#L34-L38 |
Is that the last one? Or, just one dependency instance? |
I bumped arrow version to 0.15.1 locally, so, there is no dependency from joda-time anymore. Not sure that is is safe to migrate to arrow vector 0.15.1 |
I pinged you the on-going |
There is a transitive dependency from
which still exists in hive's master: https://github.com/apache/hive/blob/master/common/pom.xml#L101-L105 |
Test build #113243 has finished for PR 26392 at commit
|
I am closing this because there is no chance of hive-common avoids dependency from joda-time any time soon. |
What changes were proposed in this pull request?
Removed direct dependency from joda-time.
Why are the changes needed?
To reduce number of direct Spark dependencies.
Does this PR introduce any user-facing change?
No, only if users depend on joda-time transitively.
How was this patch tested?
By building Spark via
./build/sbt -Phive -Phive-thriftserver package