Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils #26423

Closed
wants to merge 3 commits into from
Closed

[SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils #26423

wants to merge 3 commits into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Nov 7, 2019

What changes were proposed in this pull request?

Move method add/subtract/negate from CalendarInterval to IntervalUtils

Why are the changes needed?

#26410 (comment) suggested here

Does this PR introduce any user-facing change?

no

How was this patch tested?

add uts and move some

@yaooqinn yaooqinn changed the title [SPARK-29787][SQL] Move method add/subtract/negate from CalendarInterval to IntervalUtils [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils Nov 7, 2019
@yaooqinn
Copy link
Member Author

yaooqinn commented Nov 7, 2019

cc @cloud-fan @MaxGekk @maropu

MaxGekk
MaxGekk reviewed Nov 7, 2019
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala Outdated
@@ -203,6 +204,30 @@ class IntervalUtilsSuite extends SparkFunSuite {
assert(!isNegative("-1 year 380 days", 31))
}

test("negate") {
assert(negate(new CalendarInterval(1, 2, 3)) === new CalendarInterval(-1, -2, -3))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the blank line

@SparkQA
Copy link

SparkQA commented Nov 7, 2019

Test build #113374 has finished for PR 26423 at commit 43bed63.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM, can you fix the conflicts?

@yaooqinn
Copy link
Member Author

yaooqinn commented Nov 7, 2019

LGTM, can you fix the conflicts?

didn't notice that. a second.

@SparkQA
Copy link

SparkQA commented Nov 7, 2019

Test build #113377 has finished for PR 26423 at commit a7428cc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 7, 2019

Test build #113382 has finished for PR 26423 at commit 4a4bc7f.

  • This patch fails from timeout after a configured wait of 400m.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • public class DateTimeConstants

@yaooqinn
Copy link
Member Author

yaooqinn commented Nov 7, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Nov 8, 2019

Test build #113412 has finished for PR 26423 at commit 4a4bc7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • public class DateTimeConstants

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 0a03839 Nov 8, 2019
@yaooqinn yaooqinn deleted the SPARK-29787 branch November 8, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGekk MaxGekk MaxGekk approved these changes

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
5 participants
@yaooqinn @SparkQA @cloud-fan @MaxGekk @dongjoon-hyun