[SPARK-29834][SQL] DESC DATABASE should look up catalog like v2 commands #26513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceExec to make "DESC DATABASE" look up catalog like v2 commands.
|
ok to test |
cloud-fan
reviewed
Nov 14, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/DescribeNamespaceSchema.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 14, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 14, 2019
...ore/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 14, 2019
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #113762 has finished for PR 26513 at commit
|
|
Test build #113756 has finished for PR 26513 at commit
|
|
retest this please |
cloud-fan
approved these changes
Nov 14, 2019
|
Test build #113777 has finished for PR 26513 at commit
|
dongjoon-hyun
changed the title
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Nov 15, 2019
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #113850 has finished for PR 26513 at commit
|
|
retest this please |
|
Retest this please. |
imback82
approved these changes
Nov 15, 2019
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
Outdated
Show resolved
Hide resolved
|
Test build #113885 has finished for PR 26513 at commit
|
|
Test build #113896 has finished for PR 26513 at commit
|
dongjoon-hyun
approved these changes
Nov 16, 2019
|
thank you all for review and help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add DescribeNamespaceStatement, DescribeNamespace and DescribeNamespaceExec
to make "DESC DATABASE" look up catalog like v2 commands.
Why are the changes needed?
It's important to make all the commands have the same catalog/namespace resolution behavior, to avoid confusing end-users.
Does this PR introduce any user-facing change?
Yes, add "DESC NAMESPACE" whose function is same as "DESC DATABASE" and "DESC SCHEMA".
How was this patch tested?
New unit test