[SPARK-27558][CORE] Gracefully cleanup task when it fails with OOM exception #26606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #4938 has finished for PR 26606 at commit
|
|
Merged to 2.4 |
srowen
pushed a commit
that referenced
this pull request
Nov 21, 2019
…ception ### What changes were proposed in this pull request? When a task fails with OOM exception, the UnsafeInMemorySorter.array could be null. In the meanwhile, the cleanupResources() on task completion would call UnsafeInMemorySorter.getMemoryUsage in turn, and that lead to another NPE thrown. ### Why are the changes needed? Check if array is null in UnsafeInMemorySorter.getMemoryUsage and it should help to avoid NPE. ### Does this PR introduce any user-facing change? No ### How was this patch tested? It was tested manually. Closes #26606 from ayudovin/fix-npe-in-listener-2.4. Authored-by: yudovin <artsiom.yudovin@profitero.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…ception When a task fails with OOM exception, the UnsafeInMemorySorter.array could be null. In the meanwhile, the cleanupResources() on task completion would call UnsafeInMemorySorter.getMemoryUsage in turn, and that lead to another NPE thrown. Check if array is null in UnsafeInMemorySorter.getMemoryUsage and it should help to avoid NPE. No It was tested manually. Closes apache#26606 from ayudovin/fix-npe-in-listener-2.4. Authored-by: yudovin <artsiom.yudovin@profitero.com> Signed-off-by: Sean Owen <sean.owen@databricks.com> Ref: LIHADOOP-58062 RB=2549424 BUG=LIHADOOP-58062 G=spark-reviewers R=mmuralid A=mmuralid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a task fails with OOM exception, the UnsafeInMemorySorter.array could be null. In the meanwhile, the cleanupResources() on task completion would call UnsafeInMemorySorter.getMemoryUsage in turn, and that lead to another NPE thrown.
Why are the changes needed?
Check if array is null in UnsafeInMemorySorter.getMemoryUsage and it should help to avoid NPE.
Does this PR introduce any user-facing change?
No
How was this patch tested?
It was tested manually.