[SPARK-29980][SQL] Whitespaces handling for Cast and BinaryOperation between StringType and NumericTypes #26618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Here is a case, let see how it goes in different SQL engines.
spark 1.6
NULL true
spark 2.1
NULL true
spark 2.2
NULL NULL
spark 2.3
NULL NULL
spark 2.4
NULL NULL
hive
NULL true
PostgreSQL
presto
Our behavior is unstable because type coercion changed since 2.2.
Personally, I think what PostgreSQL and Presto does here is more reasonable and consistent
Currently, this pull request obeys PostgreSQL, might need further discussion against this behavior change.
Why are the changes needed?
For better dirty data auto handling, keep consistency with older version sparks
Does this PR introduce any user-facing change?
ad ut