Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30142][test-maven][BUILD] Upgrade Maven to 3.6.3 #26770

Closed
wants to merge 1 commit into from
Closed

[SPARK-30142][test-maven][BUILD] Upgrade Maven to 3.6.3 #26770

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 5, 2019

What changes were proposed in this pull request?

This PR aims to upgrade Maven from 3.6.2 to 3.6.3.

Why are the changes needed?

This will bring bug fixes like the following.

  • MNG-6759 Maven fails to use section from dependency when resolving transitive dependencies in some cases
  • MNG-6760 ExclusionArtifactFilter result invalid when wildcard exclusion is followed by other exclusions

The following is the full release note.

Does this PR introduce any user-facing change?

No. (This is a dev-environment change.)

How was this patch tested?

Pass the Jenkins with both SBT and Maven.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30142][BUILD] Upgrade Maven to 3.6.3 [SPARK-30142][BUILD][test-maven] Upgrade Maven to 3.6.3 Dec 5, 2019
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 5, 2019

Test build #114914 has finished for PR 26770 at commit 08c3b9f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 6, 2019

Test build #114915 has finished for PR 26770 at commit 08c3b9f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30142][BUILD][test-maven] Upgrade Maven to 3.6.3 [SPARK-30142][BUILD] Upgrade Maven to 3.6.3 Dec 6, 2019
@HyukjinKwon HyukjinKwon changed the title [SPARK-30142][BUILD] Upgrade Maven to 3.6.3 [SPARK-30142][test-maven][BUILD] Upgrade Maven to 3.6.3 Dec 6, 2019
@HyukjinKwon
Copy link
Member

retest this please

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@SparkQA
Copy link

SparkQA commented Dec 6, 2019

Test build #114932 has finished for PR 26770 at commit 08c3b9f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member Author

Thank you for review and merging, @HyukjinKwon .
BTW, [test-maven] was tested already via #26770 (comment) .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-30142 branch December 6, 2019 15:49
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Dec 6, 2019
### What changes were proposed in this pull request?

This PR aims to upgrade Maven from 3.6.2 to 3.6.3.

### Why are the changes needed?

This will bring bug fixes like the following.
- MNG-6759 Maven fails to use <repositories> section from dependency when resolving transitive dependencies in some cases
- MNG-6760 ExclusionArtifactFilter result invalid when wildcard exclusion is followed by other exclusions

The following is the full release note.
- https://maven.apache.org/docs/3.6.3/release-notes.html

### Does this PR introduce any user-facing change?

No. (This is a dev-environment change.)

### How was this patch tested?

Pass the Jenkins with both SBT and Maven.

Closes apache#26770 from dongjoon-hyun/SPARK-30142.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@HyukjinKwon
Copy link
Member

Oh, I missed that. thanks :-).

@dongjoon-hyun
Copy link
Member Author

Never mind. Thank you always~ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants