[SPARK-30148][SQL] Optimize writing plans if there is an analysis exception #26778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
|
ok to test |
cloud-fan
reviewed
Dec 6, 2019
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
Show resolved
Hide resolved
HeartSaVioR
reviewed
Dec 6, 2019
| case e: AnalysisException => analysisException = e.toString | ||
| } | ||
| if (analysisException.size > 0) { | ||
| QueryPlan.append(analyzed, append, verbose, addSuffix, maxFields) |
There was a problem hiding this comment.
Statements for if and else seems to be swapped.
There was a problem hiding this comment.
If we move this to try-catch (as @cloud-fan suggested), we don't need if-else.
|
Test build #114939 has finished for PR 26778 at commit
|
cloud-fan
approved these changes
Dec 6, 2019
|
Test build #114941 has finished for PR 26778 at commit
|
HyukjinKwon
approved these changes
Dec 7, 2019
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Optimized QueryExecution.scala#writePlans().
Why are the changes needed?
If any query fails in Analysis phase and gets AnalysisException, there is no need to execute further phases since those will return a same result i.e, AnalysisException.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually