[SPARK-3813][SQL] Support "case when" conditional functions in Spark SQL. #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -333,6 +338,24 @@ class SqlParser extends StandardTokenParsers with PackratParsers { | |||
| IF ~> "(" ~> expression ~ "," ~ expression ~ "," ~ expression <~ ")" ^^ { | |||
| case c ~ "," ~ t ~ "," ~ f => If(c,t,f) | |||
| } | | |||
| CASE ~> opt(expression) ~ (WHEN ~ expression ~ THEN ~ expression).* ~ | |||
There was a problem hiding this comment.
I'd prefer expression.? to opt(expression) since you're already using postfix style like .*.
| CASE ~> expression.? ~ (WHEN ~> expression ~ (THEN ~> expression)).* ~ | ||
| (ELSE ~> expression).? <~ END ^^ { | ||
| case casePart ~ altPart ~ elsePart => | ||
| val altExprs = altPart.flatMap{ |
|
QA tests have started for PR 2678 at commit
|
| case casePart ~ altPart ~ elsePart => | ||
| val altExprs = altPart.flatMap{ | ||
| case we ~ te => | ||
| Seq(casePart.fold(we)(EqualTo(_, we)),te) |
|
Thank you for reviewing it. I have updated the code as per your comments. Please review it |
1 similar comment
|
Thank you for reviewing it. I have updated the code as per your comments. Please review it |
|
QA tests have finished for PR 2678 at commit
|
|
LGTM. Thanks for working on this! |
|
@marmbrus Can you also verify this PR. Thank you. |
|
Can one of the admins verify this patch? |
|
Thanks! I've merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"case when" conditional function is already supported in Spark SQL but there is no support in SqlParser. So added parser support to it.
Author : ravipesala ravindra.pesala@huawei.com