New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-30196][BUILD] Bump lz4-java version to 1.7.0 #26823
Conversation
Test build #115056 has finished for PR 26823 at commit
|
@maropu, it looks like you need to run:
to update the dependency manifests. Thanks for submitting this PR! |
@@ -627,7 +627,7 @@ | |||
<dependency> | |||
<groupId>org.lz4</groupId> | |||
<artifactId>lz4-java</artifactId> | |||
<version>1.6.0</version> | |||
<version>1.7.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the dependency files with I missed @JoshRosen 's comment.dev/test-dependencies.sh --replace-manifest
?
oh, I forgot to do so, thanks! I'll update soon. |
LGTM, pending Jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
Test build #115057 has finished for PR 26823 at commit
|
Merged to master. |
Thanks, all. |
Thank you all! |
What changes were proposed in this pull request?
This pr intends to upgrade lz4-java from 1.6.0 to 1.7.0.
Why are the changes needed?
This release includes a performance bug (lz4/lz4-java#143) fixed by @JoshRosen and some improvements (e.g., LZ4 binary update). You can see the link below for the changes;
https://github.com/lz4/lz4-java/blob/master/CHANGES.md#170
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.