Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3827] Very long RDD names are not rendered properly in web UI #2687

Closed
wants to merge 1 commit into from

Conversation

falaki
Copy link
Contributor

@falaki falaki commented Oct 7, 2014

With Spark SQL we generate very long RDD names. These names are not properly rendered in the web UI.

This PR fixes the rendering issue.

[SPARK-3827] #comment Linking PR with JIRA

@JoshRosen
Copy link
Contributor

There are some other JIRAs dealing with long RDD names / table entries due to Spark SQL:

Does this fix those issues, too? Since it's a CSS fix, maybe it will.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have started for PR 2687 at commit fd06409.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have finished for PR 2687 at commit fd06409.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21363/Test PASSed.

@falaki
Copy link
Contributor Author

falaki commented Oct 7, 2014

@JoshRosen yes this would address both of them.

@falaki
Copy link
Contributor Author

falaki commented Oct 7, 2014

[SPARK-2915] #comment Linking pull request with JIRA
[SPARK-3297] #comment Linking pull request with JIRA

@JoshRosen
Copy link
Contributor

The names are wrapping properly now:

image

LGTM, so I'll merge this and also include it in branch-1.1, since it's a small fix. Thanks!

@asfgit asfgit closed this in d65fd55 Oct 7, 2014
asfgit pushed a commit that referenced this pull request Oct 7, 2014
With Spark SQL we generate very long RDD names. These names are not properly rendered in the web UI.

This PR fixes the rendering issue.

[SPARK-3827] #comment Linking PR with JIRA

Author: Hossein <hossein@databricks.com>

Closes #2687 from falaki/sparkTableUI and squashes the following commits:

fd06409 [Hossein] Limit width of cell when RDD name is too long

(cherry picked from commit d65fd55)
Signed-off-by: Josh Rosen <joshrosen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants