Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[SPARK-29629][SQL] Support typed integer literal expression" #26940

Closed

Conversation

gengliangwang
Copy link
Member

This reverts commit 8e667db.

@gengliangwang
Copy link
Member Author

gengliangwang commented Dec 19, 2019

In PostgreSQL, all the data types in https://www.postgresql.org/docs/9.1/datatype-numeric.html are supported to create such literals. E.g. smallint '1', float '2.3'
It is odd to support 'integer' only in Spark.
Now we don't care too much about Postgrel compatibility, so I suppose we are not going to add full support for all numeric type literals in this form.

@gengliangwang
Copy link
Member Author

@yaooqinn
Copy link
Member

+1, LGTM

@maropu
Copy link
Member

maropu commented Dec 19, 2019

Looks fine to me, too.

@SparkQA
Copy link

SparkQA commented Dec 19, 2019

Test build #115531 has finished for PR 26940 at commit 82a33b2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HyukjinKwon
Copy link
Member

Merged to master.

@xuanyuanking
Copy link
Member

Linked this with SPARK-30125 as well as #26763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
9 participants