[SPARK-28083][SQL][FOLLOW-UP] Fix incorrect comment for LIKE ... ESCAPE #26962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Dec 20, 2019
| @@ -38,7 +38,7 @@ object StringUtils extends Logging { | |||
| * throw an [[AnalysisException]]. | |||
| * | |||
| * @param pattern the SQL pattern to convert | |||
| * @param escapeChar the escape string contains one character. | |||
| * @param escapeChar the escape character. | |||
There was a problem hiding this comment.
This isn't an exposed API and rather a nit. Usually such followups or PRs are discouraged.
There was a problem hiding this comment.
Yeah "the escape character as a one-character string" would be a little more accurate but w/e
HyukjinKwon
approved these changes
Dec 20, 2019
|
@HyukjinKwon OK. I get it. |
|
Test build #115612 has finished for PR 26962 at commit
|
maropu
approved these changes
Dec 20, 2019
Ngone51
reviewed
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up to #25001
The comment of StringUtils.escapeLikeRegex has one mistake.
Why are the changes needed?
Comment mistake.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists UT