[SPARK-29914][ML][FOLLOWUP] fix SQLTransformer & VectorSizeHint toString method #26999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I manually scan other impls, and do not find other similar places. |
|
Test build #115722 has finished for PR 26999 at commit
|
fqaiser94
pushed a commit
to fqaiser94/spark
that referenced
this pull request
Mar 30, 2020
…ing method ### What changes were proposed in this pull request? 1,modify the toString in SQLTransformer & VectorSizeHint 2,add toString in RegexTokenizer ### Why are the changes needed? in SQLTransformer & VectorSizeHint , `toString` methods directly call getter of param without default values. This will cause `java.util.NoSuchElementException` in REPL: ```scala scala> val vs = new VectorSizeHint() java.util.NoSuchElementException: Failed to find a default value for size at org.apache.spark.ml.param.Params.$anonfun$getOrDefault$2(params.scala:780) at scala.Option.getOrElse(Option.scala:189) ``` ### Does this PR introduce any user-facing change? No ### How was this patch tested? existing testsuites Closes apache#26999 from zhengruifeng/fix_toString. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: zhengruifeng <ruifengz@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1,modify the toString in SQLTransformer & VectorSizeHint
2,add toString in RegexTokenizer
Why are the changes needed?
in SQLTransformer & VectorSizeHint ,
toStringmethods directly call getter of param without default values.This will cause
java.util.NoSuchElementExceptionin REPL:Does this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites