[SPARK-30355][CORE] Unify isExecutorActive between CoarseGrainedSchedulerBackend and DriverEndpoint #27012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #115797 has finished for PR 27012 at commit
|
|
retest this please. |
|
Test build #115807 has finished for PR 27012 at commit
|
|
thanks, merging to master! |
|
Thanks @jiangxb1987 @cloud-fan |
fqaiser94
pushed a commit
to fqaiser94/spark
that referenced
this pull request
Mar 30, 2020
…ulerBackend and DriverEndpoint ### What changes were proposed in this pull request? Unify `DriverEndpoint. executorIsAlive()` and `CoarseGrainedSchedulerBackend .isExecutorActive()`. ### Why are the changes needed? `DriverEndPoint` has method `executorIsAlive()` to check wether an executor is alive/active, while `CoarseGrainedSchedulerBackend` has method `isExecutorActive()` to do the same work. But, `isExecutorActive()` seems forget to consider `executorsPendingLossReason`. Unify these two methods makes behavior be consistent between `DriverEndPoint` and `CoarseGrainedSchedulerBackend` and make code more easier to maintain. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass Jenkins. Closes apache#27012 from Ngone51/unify-is-executor-alive. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Unify
DriverEndpoint. executorIsAlive()andCoarseGrainedSchedulerBackend .isExecutorActive().Why are the changes needed?
DriverEndPointhas methodexecutorIsAlive()to check wether an executor is alive/active, whileCoarseGrainedSchedulerBackendhas methodisExecutorActive()to do the same work. But,isExecutorActive()seems forget to considerexecutorsPendingLossReason. Unify these two methods makes behavior be consistent betweenDriverEndPointandCoarseGrainedSchedulerBackendand make code more easier to maintain.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Jenkins.