[SPARK-29967][ML][FOLLOWUP] KMeans Cleanup #27014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Dec 26, 2019
| @@ -258,7 +258,6 @@ class KMeans private ( | |||
| val distanceMeasureInstance = DistanceMeasure.decodeFromString(this.distanceMeasure) | |||
|
|
|||
| val dataVectorWithNorm = data.map(d => d._1) | |||
| val weights = data.map(d => d._2) | |||
There was a problem hiding this comment.
this var is unused
zhengruifeng
commented
Dec 26, 2019
| @@ -284,7 +283,6 @@ class KMeans private ( | |||
| // Execute iterations of Lloyd's algorithm until converged | |||
| while (iteration < maxIterations && !converged) { | |||
| val costAccum = sc.doubleAccumulator | |||
| val countAccum = sc.longAccumulator | |||
There was a problem hiding this comment.
Just found that costAccum also records the count
zhengruifeng
commented
Dec 26, 2019
| @@ -232,7 +232,7 @@ class KMeans private ( | |||
| val zippedData = data.zip(norms).map { case ((v, w), norm) => | |||
| (new VectorWithNorm(v, norm), w) | |||
| } | |||
| zippedData.persist() | |||
| zippedData.persist(StorageLevel.MEMORY_AND_DISK) | |||
There was a problem hiding this comment.
Keep in line with other intermediate RDDs persisted in KMeans
|
Test build #115805 has finished for PR 27014 at commit
|
srowen
reviewed
Dec 26, 2019
| @@ -42,10 +42,10 @@ class KMeansModel (@Since("1.0.0") val clusterCenters: Array[Vector], | |||
| private[spark] val numIter: Int) | |||
| extends Saveable with Serializable with PMMLExportable { | |||
|
|
|||
| private val distanceMeasureInstance: DistanceMeasure = | |||
| @transient private lazy val distanceMeasureInstance: DistanceMeasure = | |||
There was a problem hiding this comment.
Is the reason that this not serializable? if it's just to not serialize it, it might not be worth the overhead of lazy, but won't matter much. I can understand not serializing the cluster centers twice, effectively
fqaiser94
pushed a commit
to fqaiser94/spark
that referenced
this pull request
Mar 30, 2020
### What changes were proposed in this pull request? 1, remove unused imports and variables 2, remove `countAccum: LongAccumulator`, since `costAccum: DoubleAccumulator` also records the count 3, mark `clusterCentersWithNorm` in KMeansModel trasient and lazy, since it is only used in transformation and can be directly generated from the centers. ### Why are the changes needed? 1,remove unused codes 2,avoid repeated computation 3,reduce broadcasted size ### Does this PR introduce any user-facing change? No ### How was this patch tested? existing testsuites Closes apache#27014 from zhengruifeng/kmeans_clean_up. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: zhengruifeng <ruifengz@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, remove unused imports and variables
2, remove
countAccum: LongAccumulator, sincecostAccum: DoubleAccumulatoralso records the count3, mark
clusterCentersWithNormin KMeansModel trasient and lazy, since it is only used in transformation and can be directly generated from the centers.Why are the changes needed?
1,remove unused codes
2,avoid repeated computation
3,reduce broadcasted size
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites