Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-30376][ML] Unify the computation of numFeatures #27037

Closed
wants to merge 1 commit into from
Closed

[SPARK-30376][ML] Unify the computation of numFeatures #27037

wants to merge 1 commit into from

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

using MetadataUtils.getNumFeatures to extract the numFeatures

Why are the changes needed?

may avoid first/head job if metadata has attrGroup

Does this PR introduce any user-facing change?

No

How was this patch tested?

existing testsuites

@zhengruifeng
init
90b4b4f 
int
@SparkQA
Copy link

SparkQA commented Dec 29, 2019

Test build #115905 has finished for PR 27037 at commit 90b4b4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen approved these changes Dec 29, 2019
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pending tests

@zhengruifeng
Copy link
Contributor Author

Merged to master, thanks @srowen for reviewing!

@zhengruifeng zhengruifeng deleted the unify_numFeatures branch December 30, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
ML
Projects
None yet
Milestone
No milestone
3 participants
@zhengruifeng @SparkQA @srowen