Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile #27156

Closed
wants to merge 2 commits into from

Conversation

shaneknapp
Copy link
Contributor

What changes were proposed in this pull request?

fixing a broken build:
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.7-hive-1.2/3/console

Why are the changes needed?

the build is teh borked!

Does this PR introduce any user-facing change?

newp

How was this patch tested?

by the build system

@dongjoon-hyun dongjoon-hyun changed the title [SQL] fix 101 length line [MINOR][SQL] Fix 101 length line Jan 9, 2020
@dongjoon-hyun dongjoon-hyun changed the title [MINOR][SQL] Fix 101 length line [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile Jan 9, 2020
@shaneknapp
Copy link
Contributor Author

lol thanks @dongjoon-hyun :)

@shaneknapp
Copy link
Contributor Author

also, dare i ask why this wasn't caught in the hive-2.3 profile build?

no, i shouldn't ask. let's just move on and pretend there's nothing to see here.

@dongjoon-hyun
Copy link
Member

The code path sql/core/v1.2/... is compiled at -Phive1.2 only.
It's weird. We do the build test on GitHub Action for -Phive1.2, too. It seems that mvn build doesn't catch it.

@shaneknapp
Copy link
Contributor Author

i'll wait until the 2nd build passes scala style and then merge. no need to run the complete test suite imo.

@dongjoon-hyun dongjoon-hyun changed the title [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile Jan 9, 2020
@dongjoon-hyun
Copy link
Member

Retest this please.

@dongjoon-hyun
Copy link
Member

Sure~ We only need scalastyle check in this PR. I retriggered Jenkins with [test-hive1.2] to make it sure.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Jan 9, 2020

it just passed!

========================================================================
Running Scala style checks
========================================================================
[info] Checking Scala style using SBT with these profiles:  -Phadoop-2.7 -Phive-2.3 -Pyarn -Phive-thriftserver -Pmesos -Pspark-ganglia-lgpl -Phive -Phadoop-cloud -Pkubernetes -Pkinesis-asl
Scalastyle checks passed.

@shaneknapp
Copy link
Contributor Author

okie dokie, gonna merge this now...

========================================================================
Running Scala style checks
========================================================================
[info] Checking Scala style using SBT with these profiles:  -Phadoop-2.7 -Phive-1.2 -Phive-thriftserver -Pkinesis-asl -Phadoop-cloud -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos -Pkubernetes
Scalastyle checks passed.

@dongjoon-hyun
Copy link
Member

It's passed with hive-1.2. You can merge this~

========================================================================
Running Scala style checks
========================================================================
[info] Checking Scala style using SBT with these profiles:  -Phadoop-2.7 -Phive-1.2 -Phive-thriftserver -Pkinesis-asl -Phadoop-cloud -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos -Pkubernetes
Scalastyle checks passed.

@dongjoon-hyun
Copy link
Member

Thank you so much!

@shaneknapp shaneknapp closed this in 4d23938 Jan 9, 2020
@shaneknapp shaneknapp deleted the fix-scala-style branch January 9, 2020 23:29
@SparkQA
Copy link

SparkQA commented Jan 10, 2020

Test build #116420 has finished for PR 27156 at commit 6293fcf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 10, 2020

Test build #116428 has finished for PR 27156 at commit 5b9e13c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 10, 2020

Test build #116426 has finished for PR 27156 at commit 5b9e13c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants