[SPARK-29188][PYTHON][FOLLOW-UP] Explicitly disable Arrow execution for the test of toPandas empty types #27247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dtypes_when_empty_df = self.spark.sql(sql).filter("False").toPandas().dtypes | ||
| self.assertTrue(np.all(dtypes_when_empty_df == dtypes_when_nonempty_df)) | ||
| with self.sql_conf({"spark.sql.execution.arrow.pyspark.enabled": False}): | ||
| # SPARK-29188 test that toPandas() on an empty dataframe has the correct dtypes |
There was a problem hiding this comment.
Oh, do we need to re-open SPARK-29188 then because we know that toPandas() will fail when spark.sql.execution.arrow.pyspark.enabled=True?
There was a problem hiding this comment.
hmmm .. I will just open another one just to make the management simpler.
There was a problem hiding this comment.
I opened, here https://issues.apache.org/jira/browse/SPARK-30537.
|
Test build #116888 has finished for PR 27247 at commit
|
dongjoon-hyun
approved these changes
Jan 17, 2020
|
Thank you @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to explicitly disable Arrow execution for the test of toPandas empty types. If
spark.sql.execution.arrow.pyspark.enabledis enabled by default, this test alone fails as below:it should be best to explicitly disable for the test that only works when it's disabled.
Why are the changes needed?
To make the test independent of default values of configuration.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested and Jenkins should test.