Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-3870] EOL character enforcement #2726

Closed
wants to merge 10 commits into from
Closed

[SPARK-3870] EOL character enforcement #2726

wants to merge 10 commits into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Oct 9, 2014

We have shell scripts and Windows batch files, so we should enforce proper EOL character.

@sarutak sarutak changed the title [SPARK-3758] EOL character enforcement [SPARK-3870] EOL character enforcement Oct 9, 2014
@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2726 at commit aac51ac.

  • This patch merges cleanly.

@sarutak sarutak mentioned this pull request Oct 9, 2014
Closed
@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2726 at commit 772fd4e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2726 at commit aac51ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2726 at commit 772fd4e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 11, 2014

QA tests have started for PR 2726 at commit 7407515.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 11, 2014

QA tests have finished for PR 2726 at commit 7407515.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Oct 17, 2014

test this please.

@davies
Copy link
Contributor

davies commented Oct 31, 2014

LGTM

@JoshRosen
Copy link
Contributor

LGTM. I'm going to merge this. Thanks!

@asfgit asfgit closed this in 55ab777 Oct 31, 2014
@sarutak sarutak deleted the eol-enforcement branch April 11, 2015 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sarutak @SparkQA @davies @JoshRosen