[SPARK-28152][DOCS][FOLLOWUP] Add a migration guide for MsSQLServer JDBC dialect #27270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
|
cc @gatorsmile and @viirya |
|
Test build #116966 has finished for PR 27270 at commit
|
viirya
approved these changes
Jan 17, 2020
| @@ -344,6 +344,12 @@ license: | | |||
|
|
|||
| - Since Spark 2.4.5, `TRUNCATE TABLE` command tries to set back original permission and ACLs during re-creating the table/partition paths. To restore the behaviour of earlier versions, set `spark.sql.truncateTable.ignorePermissionAcl.enabled` to `true`. | |||
|
|
|||
| - Since Spark 2.4.5, `spark.sql.legacy.mssqlserver.numericMapping.enabled` configuration is added in order to support the legacy MsSQLServer dialect mapping behavior using IntegerType and DoubleType for SMALLINT and REAL JDBC types, respectively. To restore the behaviour of 2.4.3 and earlier versions, set `spark.sql.legacy.mssqlserver.numericMapping.enabled` to `true`. | |||
|
|
|||
| ## Upgrading from Spark SQL 2.4.3 to 2.4.4 | |||
There was a problem hiding this comment.
As 2.4.4 is already out, this doc is in 2.4.5? So maybe it should be 2.4.3 -> 2.4.5?
There was a problem hiding this comment.
IMO, although it's late for 2.4.4, 2.4.3 to 2.4.4 will be correct. When the users upgrade from 1.6.3 to 3.0.0, they need to see all previous migration guides. If there is some regression on 2.4.5, the users can use 2.4.4 instead of 2.4.5.
There was a problem hiding this comment.
For 2.4.4 release doc, I'll update spark-website repository.
|
Merged to master/2.4. |
maropu
approved these changes
Jan 18, 2020
|
Thank you, @maropu ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 18, 2020
…DBC dialect This PR adds a migration guide for MsSQLServer JDBC dialect for Apache Spark 2.4.4 and 2.4.5. Apache Spark 2.4.4 updates the type mapping correctly according to MS SQL Server, but missed to mention that in the migration guide. In addition, 2.4.4 adds a configuration for the legacy behavior. Yes. This is a documentation change.  Manually generate and see the doc. Closes #27270 from dongjoon-hyun/SPARK-28152-DOC. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 505693c) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
hahaha, I was a bit late ;) |
|
You are faster than me. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a migration guide for MsSQLServer JDBC dialect for Apache Spark 2.4.4 and 2.4.5.
Why are the changes needed?
Apache Spark 2.4.4 updates the type mapping correctly according to MS SQL Server, but missed to mention that in the migration guide. In addition, 2.4.4 adds a configuration for the legacy behavior.
Does this PR introduce any user-facing change?
Yes. This is a documentation change.
How was this patch tested?
Manually generate and see the doc.