[SPARK-30575][DOC] Document HAVING Clause of SELECT statement in SQL Reference #27284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #117047 has finished for PR 27284 at commit
|
huaxingao
reviewed
Jan 20, 2020
huaxingao
reviewed
Jan 20, 2020
| <dd> | ||
| Specifies any expression that evaluates to a result type <code>boolean</code>. Two or | ||
| more expressions may be combined together using comparision operators | ||
| ('>', '>=', ‘>’, ‘>=’, ‘=’, ‘<’ and ‘<=’, '<=>') and logical operators (AND, NOT, OR).<br><br> |
There was a problem hiding this comment.
This doesn't look right:
huaxingao
reviewed
Jan 20, 2020
| +--------+---+ | ||
|
|
||
| -- `HAVING` clause without a `GROUP BY` clause. | ||
| SELECT sum(quantity) AS sum FROM dealer HAVING sum(quantity) > 10; |
There was a problem hiding this comment.
there is an extra space between SELECT and sum
|
Test build #117075 has finished for PR 27284 at commit
|
|
Test build #117084 has finished for PR 27284 at commit
|
srowen
reviewed
Jan 20, 2020
| <dd> | ||
| Specifies any expression that evaluates to a result type <code>boolean</code>. Two or | ||
| more expressions may be combined together using comparision operators | ||
| ( <code>></code>, <code>>=</code>, <code>=</code>, <code><</code>, <code><=</code>, <code><=></code> ) |
There was a problem hiding this comment.
Same comment here as in the WHERE docs. Do you need to talk about < etc?
|
Test build #117133 has finished for PR 27284 at commit
|
srowen
approved these changes
Jan 22, 2020
|
Merged to master |
|
Thank you @srowen @huaxingao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Document HAVING clause of SELECT statement in SQL Reference Guide.
Why are the changes needed?
Currently Spark lacks documentation on the supported SQL constructs causing
confusion among users who sometimes have to look at the code to understand the
usage. This is aimed at addressing this issue.
Does this PR introduce any user-facing change?
Yes.
Before:
There was no documentation for this.
After.
How was this patch tested?
Tested using jykyll build --serve