[SPARK-30578][SQL][TEST] Explicitly set conf to use DSv2 for orc in OrcFilterSuite #27285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Jan 20, 2020
| @@ -44,6 +46,11 @@ import org.apache.spark.sql.types._ | |||
| */ | |||
| class OrcFilterSuite extends OrcTest with SharedSparkSession { | |||
|
|
|||
| override protected def sparkConf: SparkConf = | |||
There was a problem hiding this comment.
shall we do the same for the one in v1.2?
There was a problem hiding this comment.
+1 for @cloud-fan 's comment.
There was a problem hiding this comment.
Addressed for v1.2. Thanks!
There was a problem hiding this comment.
Please update the PR title and description accordingly.
|
Test build #117070 has finished for PR 27285 at commit
|
|
Test build #117064 has finished for PR 27285 at commit
|
|
retest this please |
|
Test build #117098 has finished for PR 27285 at commit
|
cloud-fan
changed the title
|
thanks, merging to master! |
|
thanks all @cloud-fan @dongjoon-hyun |
|
+1, late LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Explicitly set conf to let orc use DSv2 in
OrcFilterSuitein both v1.2 and v2.3.Why are the changes needed?
Tests should not rely on default conf when they're going to test something intentionally, which can be fail when conf changes.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Jenkins.