[SPARK-30535][SQL][FOLLOWUP] Update error message for ALTER TABLE when table is resolved to temp view #27315
Conversation
|
Test build #117205 has finished for PR 27315 at commit
|
| @@ -195,7 +195,7 @@ ALTER TABLE temp_view CHANGE a TYPE INT COMMENT 'this is column a' | |||
| struct<> | |||
| -- !query 20 output | |||
| org.apache.spark.sql.AnalysisException | |||
| temp_view is a temp view not a table.; line 1 pos 0 | |||
| Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead; line 1 pos 0 | |||
There was a problem hiding this comment.
Hi, @cloud-fan and @imback82
Cannot alter a view with ALTER TABLE. looks okay, but Please use ALTER VIEW instead looks like we mislead the users to try ALTER VIEW temp_view CHANGE a TYPE INT COMMENT 'this is column a'.
There was a problem hiding this comment.
The other changes in this PR are the same. The directional message parts look misleading.
There was a problem hiding this comment.
This is a good point. How about just Cannot alter a temp view with ALTER TABLE. as the error message?
There was a problem hiding this comment.
+1 for @cloud-fan 's advice.
|
cc @imback82 @cloud-fan I'm planning to revert #27243 because of reasons described in #27243 (comment), therefore please hold off on merging this PR. |
What changes were proposed in this pull request?
This PR address: #27243 (comment).
The error is now the same whether a table is resolved to a view or a temp view for ALTER TABLE commands.
Why are the changes needed?
To unify the error message regardless of whether a table is resolved to a view or a temp view for ALTER TABLE commands.
Does this PR introduce any user-facing change?
The previous error message:
New error message (same as view):
How was this patch tested?
Updated existing tests to reflect the new error message.