New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-30603][SQL] Move RESERVED_PROPERTIES from SupportsNamespaces and TableCatalog to CatalogV2Util #27318
Conversation
Test build #117228 has finished for PR 27318 at commit
|
Test build #117233 has finished for PR 27318 at commit
|
* A property to specify the location of the namespace. If the namespace | ||
* needs to store files, it should be under this location. | ||
*/ | ||
String PROP_LOCATION = "location"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These property names should remain in the public class, as we need the implementations to read and know them.
The only thing interval is which properties are reserved. We should move the RESERVED_PROPERTIES
to CatalogV2Utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see
sorry it conflicts, can you resolve it frist? |
Test build #117282 has finished for PR 27318 at commit
|
thanks for your reminding @cloud-fan, I've cleaned the conflicts. |
Test build #117287 has finished for PR 27318 at commit
|
retest this please |
sorry it conflicts again... |
updated |
Test build #117308 has finished for PR 27318 at commit
|
Test build #117314 has finished for PR 27318 at commit
|
Test build #117315 has finished for PR 27318 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master. Thank you, @yaooqinn and @cloud-fan .
(cc @viirya. It seems that CRAN issue is fixed. Thank you always.)
What changes were proposed in this pull request?
In this PR, I propose to move the
RESERVED_PROPERTIES
s fromSupportsNamespaces
andTableCatalog
toCatalogV2Util
, which can keepRESERVED_PROPERTIES
safe for interval usages only.Why are the changes needed?
the
RESERVED_PROPERTIES
should not be changed by subclassesDoes this PR introduce any user-facing change?
no
How was this patch tested?
existing uts