Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30607][SQL][PYSPARK][SPARKR] Add overlay wrappers for SparkR and PySpark #27325

Closed
wants to merge 4 commits into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented Jan 22, 2020

What changes were proposed in this pull request?

This PR adds:

  • pyspark.sql.functions.overlay function to PySpark
  • overlay function to SparkR

Why are the changes needed?

Feature parity. At the moment R and Python users can access this function only using SQL or expr / selectExpr.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

New unit tests.

Signed-off-by: zero323 <mszymkiewicz@gmail.com>
Signed-off-by: zero323 <mszymkiewicz@gmail.com>
@SparkQA
Copy link

SparkQA commented Jan 22, 2020

Test build #117254 has finished for PR 27325 at commit 9069fe3.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Signed-off-by: zero323 <mszymkiewicz@gmail.com>
@SparkQA
Copy link

SparkQA commented Jan 22, 2020

Test build #117258 has finished for PR 27325 at commit 0e3119e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

R/pkg/R/functions.R Outdated Show resolved Hide resolved
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@SparkQA
Copy link

SparkQA commented Jan 23, 2020

Test build #117271 has finished for PR 27325 at commit 9ae01fa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@zero323
Copy link
Member Author

zero323 commented Jan 23, 2020

Thanks @HyukjinKwon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants